search

gjuliao / leaderboard_js

This is simple app that calls the Leadorboard API using es6 syntax
0 stars 0 forks source link

Added layout to Leaderboard App #2

Closed gjuliao closed 1 year ago

gjuliao commented 1 year ago

Requirements

julie-ify commented 1 year ago

Hi @gjuliao,

While you made a great effort in this project, unfortunately, I cannot proceed to review your code.

Invalid Code Review Request

Your readme file is blank. Kindly update your readme using the template

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.

gjuliao commented 1 year ago

Hi Manel,

Readme file is in the main code. Please see the code besides the pull request.

https://github.com/gjuliao/leaderboard_js @ha-manel

Thank!

On Tue, 20 Dec 2022 at 11:58 AM Manel Hammouche @.***> wrote:

@.**** commented on this pull request. STATUS: INVALID 🔴

Hi @gjuliao https://github.com/gjuliao I'm sure you put a lot of effort into this project but this PR is invalid because your README file is empty😓 kindly copy the content of this template https://github.com/microverseinc/readme-template and replace the placeholder text with information about your project 👍

Kindly fix the issue and submit the PR for review again 👍 Best of luck!

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy https://microverse.zendesk.com/hc/en-us/articles/1500004088561 you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form https://airtable.com/shrQAqnBwek5a0O0s.

— Reply to this email directly, view it on GitHub https://github.com/gjuliao/leaderboard_js/pull/2#pullrequestreview-1224832751, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO3AOMBIE2752NU76KBDFG3WOHQUJANCNFSM6AAAAAATEVQ5UM . You are receiving this because you were mentioned.Message ID: @.***>

ha-manel commented 1 year ago

@gjuliao Kindly add it for this branch too 😅