tabindex="0" gets only added in readonly mode. When keyboard tabbing,…

gjunge / rateit.js

Rating plugin for jQuery. Fast, Progressive enhancement, touch support, icon-font support, highly customizable, unobtrusive JavaScript (using HTML5 data-* attributes), RTL support, supports as many stars as you'd like, and also any step size.

MIT License

161 stars 45 forks source link

tabindex="0" gets only added in readonly mode. When keyboard tabbing,… #23

Closed MPolleke closed 5 years ago

MPolleke commented 5 years ago

tabindex="0" gets only added in readonly mode. When keyboard tabbing, no focus is needed in readonly mode.

Fixes issue #22: https://github.com/gjunge/rateit.js/issues/22

I (We) decided to not just leave the value for tabindex empty, because looking at the documentation it looked like a value of "0" is the default. It is safer to just not add the attribute alltogether in readonly mode.

For some reason both my editors added a newline at the end of the file. I hope that is not a problem.

gjunge commented 5 years ago

Thanks for the PR, looks great.

I'll merge it now, and tomorrow publish to NPM & NuGet

MPolleke commented 5 years ago

Thank you :)

Hartstikke bedankt as well