search

gjwgit / rattleng

The New Generation R Analytics Desktop App
GNU General Public License v3.0
20 stars 8 forks source link

QUIT: On quitting the app ask if to save the script.R #188

Closed gjwgit closed 1 month ago

gjwgit commented 3 months ago

Description

For the desktop apps there is usually a way to capture the user pressing the Quit/Close button from the window manager. This should popup a dialog to offer to save the SCRIPT into script.R using the same widget as in the SCRIPT feature's SAVE button.

zheyxu commented 2 months ago

flutter_window_close: ^1.0.0 is a relevant package but does not work at macOS version. Check the issue https://github.com/zonble/flutter_window_close/issues/15

gjwgit commented 2 months ago

So flutter_window_close works well for windows and linux but not for MacOS apparently.

Lutra-Fs commented 1 month ago

I can implement this feature in PR #442, along with the confirmation dialog for closing. Please let me know if you have any thoughts or feedback.

zheyxu commented 1 month ago

Thanks @Lutra-Fs, once #442 is merged, I can easily implement this issue. It seems that package flutter_window_close is no longer needed. @gjwgit