VISUAL: Do not allow GROUP BY with more than 20 levels

gjwgit / rattleng

The New Generation R Analytics Desktop App

GNU General Public License v3.0

20 stars 8 forks source link

Closed gjwgit closed 1 month ago

gjwgit commented 2 months ago

For the GROUP BY do not list any categoric variables with more than 10 categories.

gjwgit commented 2 months ago

Once we introduce character types then simply list all factors here again since the suer may override factor/character typpes in ROLES.

gjwgit commented 1 month ago

If variables with > 20 levels are auto IGNORED, then perhaps this issue becomes mute - once issue #404 resolve, decide what to do here.

zheyxu commented 1 month ago

zheyxu commented 1 month ago

Currently have not find a way to test the Dropdown menu widget, thus the integration test does not cover the page in screenshot.

gjwgit commented 1 month ago

Thanks.

[ ] Once you have a screenshot of the output all successful make qtest.tmp we can merge this.

gjwgit commented 1 month ago

Once we found a way to get the list of variables in the DropDown then the test will be:

[ ] Load LARGE dataset
[ ] EXPLORE -> VISUAL -> GROUP BY - variables are gender (default), state, marital status.
[ ] DATASET -> ROLES -> IGNORE state
[ ] EXPLORE -> VISUAL -> GROUP BY - variables are gender (default), marital status.

zheyxu commented 1 month ago