DATASET: After BUILD go to ROLES page.

gjwgit / rattleng

The New Generation R Analytics Desktop App

GNU General Public License v3.0

20 stars 8 forks source link

DATASET: After BUILD go to ROLES page. #413

Closed gjwgit closed 1 day ago

gjwgit commented 2 weeks ago

Description

After loading the dataset proceed to the ROLES page. This is what I always do as a user, so probably good to do it by default.

Why

So that we show a new user that a new page is generated and they should get insight from this new page. It helps to train the user into using the navigation. It is also the first thing I need to do as an experienced user - go to PAGE 1 - and so it is useful to make this easier for me.

junhaow1 commented 1 week ago

demo video : https://github.com/user-attachments/assets/66254b00-e801-4325-af29-18da6fb02377

junhaow1 commented 1 week ago

Provider for PageController: I created a pageControllerProvider using Riverpod’s StateProvider to manage the PageController.
Access PageController in DatasetDisplay: In the DatasetDisplay widget, I use ref.watch(pageControllerProvider) to access the PageController and attach it to the PageView.
Update PageController in DatasetPopup: In the DatasetPopup widget, I use ref.read(pageControllerProvider) to get access to the PageController and move to the second page after the dataset is loaded.

gjwgit commented 1 week ago

We can head toward using PageViewer() as a replacement for Page? Desirable functionality

[x] Touchpad pan left and right
[x] After the dataset is loaded go to the next page (ROLES).
[x] Expose navigation buttons along the bottom with circles we can tap
[x] Once tested for DATASET, for any FEATURE after the build button is tapped move to the next page
[ ] When returning to the DATASET tab if a dataset is loaded then by default show the ROLES page SPLIT INTO A SEPARATE ISSE AND RAISE A PR.

Lutra-Fs commented 1 week ago

Is this a duplicate of #202?

gjwgit commented 1 week ago

Yes it is. Thanks for picking that up @Lutra-Fs. I have closed #202

gjwgit commented 1 week ago

The current branch kev/413_page is great so far. Now to add the navigation. Then migrate to replace Page (with PageView).

junhaow1 commented 1 week ago

junhaow1 commented 5 days ago

https://github.com/gjwgit/rattleng/pull/483 PR created

junhaow1 commented 5 days ago

New issue created to fix integration tests: https://github.com/gjwgit/rattleng/issues/485

gjwgit commented 2 days ago

AS per #483 this is failing for me at present. Moving back to in progress.