IMPUTE: Constant text field only accessible when CONSTANT enabled - Githubissues

gjwgit / rattleng

The New Generation R Analytics Desktop App

GNU General Public License v3.0

21 stars 9 forks source link

IMPUTE: Constant text field only accessible when CONSTANT enabled #515

Closed gjwgit closed 1 month ago

gjwgit commented 1 month ago

Description

[x] The Constant text field should be enabled only when the CONSTANT chip is active.
[x] If variable is numeric then the default value (if not already set) should be 0
[x] If the variable is categoric then the default value (if not already set) should be 'Missing'
[x] The Constant can not be character for a numeric variable.
[x] For a categoric variable it is okay to be numeric - the R code uses "0"
[x] Remove the Zero/Missing chip - it is redundant
[x] Add tooltips for the chips and the TextField
[x] Add gap between the Constant chip and the other chips
[x] Remove the large gap (small gap only) between Constant chip and Constant TextField

Why

So that we remove redundancy, explain each operation, and layout the options to better support the user.

junhaow1 commented 1 month ago

demo video:

https://github.com/user-attachments/assets/a16f246a-027d-4326-9fe0-4b74c892f57e

junhaow1 commented 1 month ago

https://github.com/gjwgit/rattleng/pull/523 PR created

gjwgit commented 1 month ago

Changes requested to the PR.

junhaow1 commented 1 month ago

Changes requested to the PR.

https://github.com/gjwgit/rattleng/pull/523/files changed as requested

junhaow1 commented 1 month ago

junhaow1 commented 1 month ago

new demo video: @gjwgit

https://github.com/user-attachments/assets/72ec1074-3255-43a1-a9cf-fc690f2d0c8f