gjwgit / rattleng

The New Generation R Analytics Desktop App
GNU General Public License v3.0
20 stars 9 forks source link

Supports selecting file extensions, and adds export to PDF and PNG #555

Closed Lutra-Fs closed 2 weeks ago

Lutra-Fs commented 2 weeks ago

Pull Request Details

What issue does this PR address

Checklist

Complete the check-list below to ensure your branch is ready for PR.

Flutter Style Guide: https://survivor.togaware.com/gnulinux/flutter-style.html

Finalising

Once PR discussion is complete and reviewers have approved:

Lutra-Fs commented 2 weeks ago

Hey! I tried running make qtest on my Windows machine but ran into some environment issues. I wanted to get back to this project, but I've been swamped with assignments between mid-semester break and the end of teaching period. Haven't had a chance to look at it at all during that time. Finally now that classes are over, I can pick it up again!

Lutra-Fs commented 2 weeks ago

7ce9c69c9040a4ee93ac942ce5b5198cf6f0a254 introduce pipe uses date command, which I get this error: cmd:

E:\rattleng>date +%Y%m%d%H%M%S
The system cannot accept the date entered.
Enter the new date: (dd-mm-yy) 

pwsh:

date +%Y%m%d%H%M%S
Get-Date: Cannot bind parameter 'Date'. Cannot convert value "+%Y%m%d%H%M%S" to type "System.DateTime". Error: "String '+%Y%m%d%H%M%S' was not recognized as a valid DateTime."

make:

✦ ❯ make qtest.tmp
process_begin: CreateProcess(NULL, date +%Y%m%d%H%M%S, ...) failed.
support/flutter.mk:307: pipe: Bad file descriptor
Lutra-Fs commented 2 weeks ago

Also I think it would be better to turn https://github.com/gjwgit/rattleng/blob/dev/lib/main.dart#L66 alwaysOnTop off to avoid the annoying pop up for integration test. I have read the comment but still don't get the idea why we force the app on top of the beginning.

Lutra-Fs commented 2 weeks ago

when running qtest I found https://github.com/gjwgit/rattleng/issues/359 appears again.

Lutra-Fs commented 2 weeks ago

Ref: https://github.com/gjwgit/rattleng/issues/550 Currently on my device, multiple unrelated integration tests are failing.

gjwgit commented 2 weeks ago

Testing through the makefile is a little problematic on Windows - not developed/tested yet.

Tests are mostly working okay on Linux.

macOS on M1 is having issues with testing (and async issues) though older Mac is okay.

Thanks for the updates - I'll review shortly.

gjwgit commented 2 weeks ago

Also I think it would be better to turn https://github.com/gjwgit/rattleng/blob/dev/lib/main.dart#L66 alwaysOnTop off to avoid the annoying pop up for integration test. I have read the comment but still don't get the idea why we force the app on top of the beginning.

I'll review this again - perhaps create an issue for this. It's a good point re the testing getting focus all the time because of this. An end user's expectation is that on starting the app it should be visible. I found that on starting the app it often ended up behind other windows on Linux.