gjwgit / rattleng

The New Generation R Analytics Desktop App
GNU General Public License v3.0
20 stars 9 forks source link

SETTINGS: Theme Not Applied on Startup Until SettingsDialog is Opened #598

Closed junhaow1 closed 3 days ago

junhaow1 commented 4 days ago

Description

When starting up the app, the selected theme is not applied to generating plots unless the SettingsDialog is opened first. This issue seems to arise because the theme changes are not being applied during the app initialization or when navigating to the HomeScreen or ExploreTabs. The system may require explicitly applying the saved theme during these transitions.

Why

This issue negatively impacts the user experience, as the theme is expected to be consistent across all app functionalities upon startup. Users should not have to interact with the SettingsDialog to apply their saved preferences. Fixing this ensures the app respects user settings immediately, providing a seamless and intuitive experience.

Closing Criteria

gjwgit commented 3 days ago

I have removed the theme setting to the default on startup. I think that works now - in #324.

I have added the SETTINGS_GRAPHIC_THEME to the R scripts that use the theme so we don't need to execute the theme_default <- SETTINGS_GRAPHIC_THEME there.

Let's see if that can simplify things.

I have added Theme to the Debug tab so we ca see what's happening.

Seems to be working. Can you please check. Thanks

junhaow1 commented 3 days ago

I have removed the theme setting to the default on startup. I think that works now - in #324.

I have added the SETTINGS_GRAPHIC_THEME to the R scripts that use the theme so we don't need to execute the theme_default <- SETTINGS_GRAPHIC_THEME there.

Let's see if that can simplify things.

I have added Theme to the Debug tab so we ca see what's happening.

Seems to be working. Can you please check. Thanks

I have tested. It is working now. Thanks heaps. We could close this issue.