search

gkaindl / ambi-tv

a flexible ambilight clone for embedded linux
296 stars 85 forks source link

Feature Request: Quit Button #24

Closed Mrjohns42 closed 10 years ago

Mrjohns42 commented 10 years ago

Pretty simple, pressing "Q" or ESC should exit the program.

sn00zerman commented 10 years ago

Still on holidays, but I can't let this one pass to answer :-)

does the trick already ! best regards, Kris ## -=[http://www.digitalplayground.be]=- where fun meets technology On 13 sep 2013 10:50 "Mrjohns42" notifications@github.com wrote: > Pretty simple, pressing "Q" or ESC should exit the program. > > — > Reply to this email directly or view it on GitHub > https://github.com/gkaindl/ambi-tv/issues/24.
Mrjohns42 commented 10 years ago

Does the ambi-tv program intercept the SIGINT and cleanup before it exits?

There's probably malloc'd memory that needs to be free'd, the conf file needs to be closed, and the driver files need to be closed.

duenorh commented 10 years ago

Another feature request i'd like to see is a way to shut of leds. Like the bottom row or top row when I watch videos with 2.35:1 ratio. Would this be complicated to add as a feature?

Mrjohns42 commented 10 years ago

@duenorh, I think this can be accomplished automatically if you turn down the "autocrop-luminance-threshold" in the v4l2-grab-source component.

duenorh commented 10 years ago

@Mrjohns42 You are right about that. Thanks a lot. Should read a bit before posting I guess :)

Mrjohns42 commented 10 years ago

After reading through the code, the ambitv programs does seem to have an interrupt handler that cleans up before exit. Therefore, it is safe to exit with CTRL-C.