search

gkamradt / langchain-tutorials

Overview and tutorial of the LangChain Library
6.63k stars 1.92k forks source link

added keyword arguments for models #48

Closed AliAbadiHub closed 1 year ago

AliAbadiHub commented 1 year ago

tried to not alter any other code. vscode kept adding stuff on save, so i made these changes on github directly in the browser

gkamradt commented 1 year ago

@AliAbadiHub I'm seeing that LangChain doesn't use the model_kwargs convention

https://python.langchain.com/docs/modules/model_io/models/chat.html

What's the reason for the change?

AliAbadiHub commented 1 year ago

That's so strange it wouldn't work on jupyterlab locally without it. I'll take down the PR.

gkamradt commented 1 year ago

Cool sounds good - thank you for the edit in the first place. Have a good day!

AliAbadiHub commented 1 year ago

Likewise!