Current master does not build on Fedora

[birdsarah]

make fails with the following error

Making all in data
make[2]: Entering directory '/home/bird/Dev/misc-clones/parlatype/data'
Makefile:837: *** missing separator.  Stop.
make[2]: Leaving directory '/home/bird/Dev/misc-clones/parlatype/data'
make[1]: *** [Makefile:469: all-recursive] Error 1
make[1]: Leaving directory '/home/bird/Dev/misc-clones/parlatype'
make: *** [Makefile:401: all] Error 2

In addition, but this maybe an artifact of make failing, checked in files are modified at some point during autogen and make:

Changes not staged for commit:                                                                                                                                                   
  (use "git add <file>..." to update what will be committed)                                                                                                                     
  (use "git checkout -- <file>..." to discard changes in working directory)                                                                                                      

        modified:   libparlatype/po/ca.po                                                                                                                                 
        modified:   libparlatype/po/de.po                                                                                                                                        
        modified:   libparlatype/po/en_GB.po                                                                                                                                                                                  
        modified:   libparlatype/po/es.po                                                                                                                                       
        modified:   libparlatype/po/fi.po                                                                                                                                           
        modified:   libparlatype/po/fr.po                                                                                                                                          
        modified:   libparlatype/po/id.po                                                                                                                                    
        modified:   libparlatype/po/it.po                                                                                                                                    
        modified:   libparlatype/po/ja.po                                                                                                                                    
        modified:   libparlatype/po/kab.po                                                                                                                                          
        modified:   libparlatype/po/ku.po                                                                                                                                        
        modified:   libparlatype/po/lt.po                                                                                                                                        
        modified:   libparlatype/po/lv.po                                                                                                                                        
        modified:   libparlatype/po/ms.po                                                                                                                                        
        modified:   libparlatype/po/nl.po                                                                                                                                        
        modified:   libparlatype/po/pl.po                                                                                                                                        
        modified:   libparlatype/po/pt.po                                                                                                                                        
        modified:   libparlatype/po/sk.po                                                                                                                                        
        modified:   libparlatype/po/sv.po   

It's master, so maybe this is to be expected, 1.5.6 builds just fine. Just wanted to flag it.

Thanks for all your hard work.

[gkarsay]

Thanks for your report! Master is supposed to work all the time. Does it help to install libappstream-glib-devel?

[birdsarah]

Hi, I did not have libappstream-glib-devel installed but after installing it, I still have the same error.

The error refers to Makefile Line 837. In case it's helpful, here's an excerpt of the generated Makefile:

L830 - 840

install-man:

install-pdf: install-pdf-recursive

install-pdf-am:

install-ps: install-ps-recursive

install-ps-am:

L837 is install-ps: install-ps-recursive

And here's a bit more of the make error:

Making all in tests
make[4]: Entering directory '/home/bird/Dev/misc-clones/parlatype/libparlatype/tests'                                        
make  all-am
make[5]: Entering directory '/home/bird/Dev/misc-clones/parlatype/libparlatype/tests'                                        
make[5]: Nothing to be done for 'all-am'.
make[5]: Leaving directory '/home/bird/Dev/misc-clones/parlatype/libparlatype/tests'                                         
make[4]: Leaving directory '/home/bird/Dev/misc-clones/parlatype/libparlatype/tests'                                         
make[4]: Entering directory '/home/bird/Dev/misc-clones/parlatype/libparlatype'                                              
make[4]: Leaving directory '/home/bird/Dev/misc-clones/parlatype/libparlatype'                                               
make[3]: Leaving directory '/home/bird/Dev/misc-clones/parlatype/libparlatype'                                               
make[2]: Leaving directory '/home/bird/Dev/misc-clones/parlatype/libparlatype'                                               
Making all in data
make[2]: Entering directory '/home/bird/Dev/misc-clones/parlatype/data'                                                      
Makefile:837: *** missing separator.  Stop.
make[2]: Leaving directory '/home/bird/Dev/misc-clones/parlatype/data'                                                       
make[1]: *** [Makefile:469: all-recursive] Error 1
make[1]: Leaving directory '/home/bird/Dev/misc-clones/parlatype'                                                            
make: *** [Makefile:401: all] Error 2

[gkarsay]

Could you please make sure you have the package autoconf-archive installed, pull the latest commits (or clone again) and run ./autogen.sh again? I still think this is a problem with the APPSTREAM_XML macro in configure.ac. Now it should warn, if APPSTREAM_XML is not defined. If there is no warning, I'm somehow clueless for the moment. The output is long, the warning should be close to the top.

[birdsarah]

• I did not have autoconf-archive installed (it's not listed as a dependency).
• I pulled
• I cleaned everything out and tried again.

It worked! :fireworks: