search

gkasten / drrickorang

Dr. Rick O'Rang
71 stars 39 forks source link

Update build system to Gradle+CMake #21

Closed ggfan closed 6 years ago

ggfan commented 6 years ago

This is for https://github.com/gkasten/drrickorang/issues/20. Please kindly help review and test, thanks!

I do have question for ATrace, it is enabled inside NDK after API-23, so the min SDK set to 23; but this tool to support early versions, correct? then dlopen/dlclose() has to be used to get the lib entry pointer, could not depends on NDK for it. May you confirm?

ggfan commented 6 years ago

uploaded a patch to address code review items Thanks. added #if __ANDROID_API_ >= 23 into logging.h to use ATrace* function. Then could build to the lowest sdk level ( 14 ).

Please do a test make sure it works. After this is merge, then could enable the -Wall -Werror to fix warnings ( there are a bunch, some of them are really redundant code ), and send another patch for it.