reenable carbons for active accounts on plugin load

[alecdwm]

I'm no C developer by any means, so feel free to critique! I really needed this issue solved to further progress on getting this working in a terminal environment, so I thought I'd have a crack at it myself.

Tested in Pidgin and it seems to work. I get the Successfully automatically activated carbons message in the Pidgin dev console, and the carbon messages themselves appear to propagate between Pidgin, Gajim and Conversations (Android).

Not sure if I'm freeing the memory allocated for the list properly or not though!

Cheers

[gkdr]

Looks good! I'm currently not at home and will give it a closer look when I get back. There's not much that can go wrong here and it looks exactly the same as the solution I used in my other plugin but I just want to run it at least once myself. Can I ask how this hindered you? Shouldn't it be fixed by a client restart?

[alecdwm]

No worries!

I'm not using finch, but rather an irc gateway program called bitlbee. However bitlbee doesn't support libpurple plugins yet, so until that happens I'm hoping to instead get this working with minbif. But minbif doesn't store a list of enabled plugins, they must be enabled each time you connect!

(minbif also doesn't seem to want to trigger /slash commands in the chat, so a little bit of hacking was required to get things loaded the very first time and set that pesky carbons-enabled bool for future connections :grin:)

Currently lurch is working great in minbif, and carbons appears to be loading, but I don't actually see carbon messages in the terminal so I haven't completely figured this out yet.

[gkdr]

Oh, pretty cool! Yeah, I wasn't so sure about the command from the start, but I thought it would be helpful to not have it automatically enabled to prevent confusion if a server does not support carbons. Would it help if it was a plugin action instead of a command?

[alecdwm]

Oh, sorry for the late reply! Unfortunately, I don't think having it as a plugin action would make much of a difference, but thanks anyway :D

[gkdr]

No, I'm sorry for taking so long, I just completely forgot about it after I returned from that vacation :D

[gkdr]

It segfaulted on me and I added a few checks - after you get the account list, you need to check for each account if it is active, and if it an XMPP account. While doing that I also made it look more like my codestyle, just easier to maintain that way.