search

gkdr / libomemo

Implements OMEMO in C.
MIT License
55 stars 16 forks source link

12 byte IV for outgoing messages #24

Closed Neustradamus closed 3 years ago

Neustradamus commented 4 years ago

The XEP-0384 0.3.0 does not specify the "IV" value and the 0.3.1 version has been missing before the 0.4.0 version. All OMEMO 0.3.0 clients must send with 12-byte instead 16-byte IV.

This issues is solved in #27.

More informations:

Already good:

Linked to:

hartwork commented 3 years ago

@gkpr I don't think GitHub reaction notification is possible. It would probably very noisy. I'd be happy to help with review of issues and pull request a bit if we could do a voice/video call in English or German to coordinate so that I don't waste time going in any wrong direction or dead ends, as that would be very frustrating. If that sounds fair and interesting, please drop me a mail at firstname@lastname.org with my name filled in. Now or later, as you like and if you like.

tehnick commented 3 years ago

@gkdr As for builds for MS Windows, have in mind that there are special package managers for preparing of build environments. For example, here are libsignal-protocol-c package in a most popular ones: https://github.com/mxe/mxe/blob/master/src/libsignal-protocol-c.mk https://github.com/msys2/MINGW-packages/blob/master/mingw-w64-libsignal-protocol-c/PKGBUILD

Also it is not hard to add package to vcpkg when needed.

BTW, in MXE even libomemo package exist. But it should be updated though.

Neustradamus commented 3 years ago

@tehnick: About libomemo and MXE, there is a ticket:

Neustradamus commented 3 years ago

Some comments are hidden by default, I recall to all that:

Alpine, Debian (+ PureOS), Gentoo, Alt Linux are already perfect.

Some OS have only one package instead of 3:

Some OS maintainers have not updated packages yet -> Compatibility problem, time to update.

In more, there is a problem with the lurch package name, never same name:

hartwork commented 3 years ago

Some OS have only one package instead of 3:

  • axc
  • libomemo
  • lurch

Please note that before bothj axc and libomemo start building shared libraries (.so files) — libomemo seems done as of 0.7.0 but axc seems todo as of https://github.com/gkdr/axc/pull/17 — , providing three packages is of little extra value because you'd still need to recompile lurch when one of the other two updated because of static linking. So that needs to be improved upstream before it can really improve downstream. (I'm happy to join working on that upstream if a tight feedback loop is guaranteed.)

In more, there is a problem with the lurch package name, never same name:

Distributions have different naming schemes plus at least some follow the upstream naming as far as technically possible. The upstream name is "lurch" and not "pidgin-lurch" hence I went for "lurch" in "Gentoo" initially. Name x11-plugins/pidgin-lurch would actually fit the Gentoo naming scheme better but a rename has costs to users and developers and it would still not be in line with the other names you quote above. So let's maybe focus on renaming things that are so badly named that they impose a practical problem with regard to users of that very Linux distrubution.