search

gkdr / lurch

XEP-0384: OMEMO Encryption for libpurple.
GNU General Public License v3.0
287 stars 32 forks source link

Request for v0.7.0 Windows DLLs #167

Closed Hub-O-Gits closed 3 years ago

Hub-O-Gits commented 3 years ago

Note that I emailed EionRobb today to see if he'd be willing to do it since he did the last set. Just making a tracking issue here to note that a request is active, and to log the work details. If he decides not to do it, I will. I'm just not currently set up for it so I figured I'd ask him/others in case they are.

EionRobb commented 3 years ago

Can you try with lurch.zip

Hub-O-Gits commented 3 years ago

Much appreciated. Will test.

Btw, should we be using newer GnuPG libs? Your last releases were as follows:

EionRobb commented 3 years ago

I believe the older gcrypt dlls were needed for telegram plugin compatibility, at some point in time, but since that's been deprecated in favour of the tdlib plugin, maybe worth reconsidering :)

I'd love to statically compile gcrypt into the plugin to make installation easier, so maybe the CVE's would help prod that along

EionRobb commented 3 years ago

So I've updated the dll's at https://eion.robbmob.com/lurch/ to the latest versions for now until I can get my ducks in a row for static compiles

gkdr commented 3 years ago

thanks a lot, @EionRobb! i managed to automatically build carbons on some ci, and all the dependencies of this one prevented me from just copying that solution over. i hope someday soon i can stop burdening you with this :slightly_smiling_face: (also for this one i should probably just use github actions...)

statically compiling a more up to date grcypt into it sounds like a good idea, if you manage to figure it out maybe i can incorporate it when i finally get around to it.

@Hub-O-Gits if you could confirm that it works for you i will add the dll to the github release and close this issue.

EionRobb commented 3 years ago

@gkdr not a burden at all. happy to help try set up some CI with you if you want?

gkdr commented 3 years ago

@EionRobb thanks, that would be a great help! are you familiar with github actions already? just compiling the whole thing and running the tests is probably a good start. i realized that for the final cross-compilation step, i first need to create cross-compilation targets in the submodules. that could also be easy enough.

gkdr commented 3 years ago

@Hub-O-Gits any luck testing it? :slightly_smiling_face:

instinctualjealousy commented 3 years ago

Lurch 0.7 build not working for me- don't really want to open a separate issue for it as I could've made an oversight, and this thread does pertain to that build: "(09:21:55) plugins: C:\Users\Adam\AppData\Roaming\.purple\plugins\lurch-0.7.0.dll is not usable because the 'purple_init_plugin' symbol could not be found. Does the plugin call the PURPLE_INIT_PLUGIN() macro?" when I run the debug log at startup.

I tried the lurch.dll at root as well (same version), but then also tried this as a sanity check. This is running with the tdlib installed gcrypt and gpg-error so I assume everything's fine here. Was there a compile oversight, or is it failing silently and has a dependency I'm not meeting? 0.6.7 works as normal.

Latest Pidgin as of today, Windows 10 Pro x64.

EionRobb commented 3 years ago

Yeah, I'm an idiot. The 0.7.0 dll didn't include half the libpurple lib... amazing that it compiled at all!

lurch.zip is 0.7.0 with all the .c code in there. I even went as far as testing it this time gasp

Have updated the files on https://eion.robbmob.com/lurch/ too. Sorry about that :(

instinctualjealousy commented 3 years ago

Thanks for the fix. It's no big deal, mistakes happen. Shocked it compiled like that though. Anyway, if it wasn't me, someone else would've caught it!

ghost commented 3 years ago

lurch 0.7 still not working for me on windows

XML parser error for JabberStream 0343AFD0: Domain 3, code 100, level 1: xmlns: URI eu.siacs.conversations.axolotl is not absolute

(22:44:16) g_log: xmlnode_to_str_helper: assertion `node != NULL' failed
(22:44:16) g_log: jabber_send_raw: assertion `data != NULL' failed
(22:44:16) g_log: jabber_is_stanza: assertion `packet != NULL' failed
(22:44:16) jabber: XML parser error for JabberStream 03398850: Domain 3, code 100, level 1: xmlns: URI eu.siacs.conversations.axolotl is not absolute
(22:44:16) lurch: lurch_bundle_create_session: failed to import xml into bundle (-12000)
(22:44:16) lurch: lurch_bundle_request_cb: failed to create a session (-12000)
EionRobb commented 3 years ago

@ecxod your debug log is showing that it is loading and unrelated to this thread. Just keep your issue in #172 :)

ghost commented 3 years ago

thanks for fixing lurch :)) This topic can be closed now as we habe the dll.

gkdr commented 3 years ago

glad it works for you now, @ecxod!

i'm reading this as: the new dll works. i still had the old file on the releases page, so i updated it there. and i think i can finally close this issue :slightly_smiling_face: