root-hardenedvault commented 3 years ago

The returned value of xmlnode_get_data() should be released with g_free(), as stated in xmlnode.h of libpurple.

Signed-off-by: HardenedVault root@hardenedvault.net

codecov-io commented 3 years ago

Codecov Report

Merging #168 (84ced79) into dev (7bd9cee) will decrease coverage by 0.08%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              dev     #168      +/-   ##
==========================================
- Coverage   22.25%   22.16%   -0.09%     
==========================================
  Files           4        4              
  Lines        2103     2111       +8     
==========================================
  Hits          468      468              
- Misses       1635     1643       +8

Impacted Files	Coverage Δ
src/lurch.c	`0.00% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7bd9cee...84ced79. Read the comment docs.

gkdr commented 3 years ago

Thanks, good catch. the second instance is code I should remove soon, as it should be handled by the carbons plugin...

gkdr / lurch

Fix misuse of xmlnode_get_data() #168

Codecov Report