search

gkindel / csv-js

A Comma-Separated Values parser for JavaScript. Standards-based, stand alone, and no regular expressions.
http://gkindel.github.io/cxv-js/csv.html
106 stars 35 forks source link

Absence of tags interferes with usage as bower dependency. #17

Closed nleclerc closed 9 years ago

nleclerc commented 9 years ago

I'm using this lib as a bower dependency and commits pushed today have broken AMD support. Problem is now i can't easily force a specific working version since the repo does not contain proper tags.

Please add tags and bump version number in bower.json accordingly.

c0bra commented 9 years ago

+1

gkindel commented 9 years ago

Do you have more details on the AMD errors you're seeing? We're looking at node right now, but are you using RequireJS?

nleclerc commented 9 years ago

I am indeed using requirejs. And it's really a simple fix that i already submitted in this pull request: https://github.com/gkindel/CSV-JS/pull/18

gkindel commented 9 years ago

pulled in #18

c0bra commented 9 years ago

I am still getting an error: 

TypeError: 'undefined' is not an object (evaluating 'context[name] = definition()')
  at csv.js:347
nleclerc commented 9 years ago

@gkindel You closed the issue but you didn't address the tagging problem.

@c0bra are you sure you're using the latest version ?

c0bra commented 9 years ago

@nleclerc I believe so. I can try force-installing and checking the commit hash.

nleclerc commented 9 years ago

I'm asking because i'm quite sure my fix works since i'm using it in production as we speak.

gkindel commented 9 years ago

a tag has been added. https://github.com/gkindel/CSV-JS/releases/tag/v1.1.1

nleclerc commented 9 years ago

Cool, thx.

On Tue Dec 16 2014 at 8:31:46 PM Greg Kindel notifications@github.com wrote:

a tag has been added. https://github.com/gkindel/CSV-JS/releases/tag/v1.1.1

— Reply to this email directly or view it on GitHub https://github.com/gkindel/CSV-JS/issues/17#issuecomment-67217280.