search

gkioxari / ActionTubes

source code for Finding Action Tubes, CVPR 2015
Other
65 stars 39 forks source link

A bug in the train_jhmdb.m #3

Closed iveel closed 8 years ago

iveel commented 8 years ago

train_jhmdb.m: line 140, 141 [~, ~, dups] = intersect(caches{j}.keys, keys{j}, 'rows'); assert(isempty(dups));

Above two lines always gives assertion error. Do you think these lines are necessary as the duplicated entries are already checked in the "get_negative_features" function at line 133.

gkioxari commented 8 years ago

They might not be necessary, as you point out, but it would be good to see why the assertion fails. Is dups non empty for you?

iveel commented 8 years ago

Because, in the first loop (as caches are initialized empty at line 111) dups is always empty.

gkioxari commented 8 years ago

Then I would recommend adding an if statement that would not make it crash in the case that the cache.keys is empty.