Unexpected behaviour when upgrading from v0.0.10 to v0.0.12

[danielesteban]

I beleive this was introduced also on: https://github.com/gkjohnson/three-bvh-csg/commit/5009a216b9e1c8b2bc4268e84e17ae66cc82982c

Here's with v0.0.12:

Here's with https://github.com/gkjohnson/three-bvh-csg/commit/f50feeacfab86bfc9f138c6d48c9c7e59e577b64:

jsfiddle: https://jsfiddle.net/9kLhuqn1/3/

test repo:

git clone --recursive https://github.com/danielesteban/csgtest.git
cd csgtest
pnpm install
pnpm start
# Open: http://localhost:8080/

# If you do this it works as intended
cd three-bvh-csg/
git checkout f50feeacfab86bfc9f138c6d48c9c7e59e577b64

[danielesteban]

Ah! And if you're curious this is what I changed from the #173 example that got fixed. https://github.com/danielesteban/csgtest/commit/36d597c08453bb48ad05c0f74f4bb7d5c7b59b15#diff-27653c212e1cfe533e4eb2f7d0d3f89604c9de48a09583b4cbbbcbd08a07da79 Just added a cone at the bottom of the base and moved the camera to better illustrate the issue.

[danielesteban]

Been doing some digging and made an even simpler example. This one is just an addition between a box and a cone: https://jsfiddle.net/z4cnpsra/38/

Here's with v0.0.10:

Here's with v0.0.12:

In the new version it creates sort of like an interior face when merging the box and the cone. I dunno if any of this is related. but seems it could be the root of the issue I posted on the previous example.

[gkjohnson]

Should be fixed now in #178. Can you give it a check before I merge and publish? A simple way is to just use the commit link index.js from that PR via githack to test the functionality:

https://raw.githack.com/gkjohnson/three-bvh-csg/d2f7d1221476e22b8769402b8d7342b593d0c72b/src/index.js

There was another longer standing bug that this exposed relating to coplanar faces, as well. Thanks again for submitting minimal repros and hunting down the commits!

[danielesteban]

Just tested all the minimal examples with the #178 patch and everything works as intended as far as I can tell.

Also tested the more complex ones that originated the issue and everything is also working as intended:

You're so welcome. I'm glad I was able to help. And thank you for this amazing library! I just couldn't have done all this geometry without it.

[gkjohnson]

Awesome! Just published a new version