search

gkjohnson / three-bvh-csg

A flexible, memory compact, fast and dynamic CSG implementation on top of three-mesh-bvh
MIT License
552 stars 45 forks source link

Property 'customProgramCacheKey' in type 'GridMaterial' is not assignable to the same property in base type 'MeshPhongMaterial' #66

Closed kirevdokimov closed 1 year ago

kirevdokimov commented 1 year ago 
Property 'customProgramCacheKey' in type 'GridMaterial' is not assignable to the same property in base type 'MeshPhongMaterial'.
  Type '() => boolean' is not assignable to type '() => string'.
    Type 'boolean' is not assignable to type 'string'
gkjohnson commented 1 year ago

Can you please provide more context? Where is this failing?

kirevdokimov commented 1 year ago

It's not failing while you doing it typeless, but if you check types (via typescript cli for example), it's incompatible to each other. Not a crucial thing in general, but a good thing to fix and an important thing to make appropriate types for #67