gkjohnson / three-bvh-csg

A flexible, memory compact, fast and dynamic CSG implementation on top of three-mesh-bvh
MIT License
552 stars 45 forks source link

Missing Triangle #69

Closed gkjohnson closed 1 year ago

gkjohnson commented 1 year ago

In the hierarchy demo.

image

Edit:

This looks like it's a result of incorrect coplanar operation results - specifically with the "frame" component.

image
AngyDev commented 1 year ago

Hi, I tried several changes, but if I set the width of the first frame from 2 to 2.1, the issue disappears. I don't understand why, but can it be a solution?

gkjohnson commented 1 year ago

This issue is a bit trickier - adjusting the geometry itself could avoid the problem but ideally the CSG operations should never result in a mesh hole regardless of the shape. So there's something going on in the numerical robustness or something of the CSG computations. I'd like to get #68 and #51 going to help make it easier to track these issues down and fix them.