Add typescript - Githubissues

gkjohnson / three-bvh-csg

A flexible, memory compact, fast and dynamic CSG implementation on top of three-mesh-bvh

MIT License

552 stars 45 forks source link

Add typescript #71

Closed AngyDev closed 1 year ago

AngyDev commented 1 year ago

Related issue: #65

I added the typescript configuration and the typescript lint checks in the package.json script.
I added the index.d.ts file, but I'm not sure about some points.

For example, the Constants type, the HalfEdgeHelper class, I added the code but it is commented because I'm not sure which is the correct type of the halfEdge parameter.

Maybe it's all a mess 😅, please tell me what you think.

AngyDev commented 1 year ago

The indentation issue was only about my formatter 😅 I did the changes that you suggested. I hope it is correct

gkjohnson commented 1 year ago

Excellent, thank you again! This is a great addition.

If you're still interested in digging into the code a bit more adding some documentation for new classes #72 would be another good place to dive in - I can help provide insight on what some of these different classes do and why, as well. Of course no pressure, though, I appreciate the help!