search

gkjohnson / three-gpu-pathtracer

Path tracing renderer and utilities for three.js built on top of three-mesh-bvh.
https://gkjohnson.github.io/three-gpu-pathtracer/example/bundle/index.html
MIT License
1.27k stars 125 forks source link

Possible transmission regressions on model viewer screenshots #545

Closed gkjohnson closed 4 months ago

gkjohnson commented 4 months ago

Compared to model-viewer screenshots taken with v0.0.13. Could be related to model changes? Or material changes. Should test on windows to avoid mac regressions.

Before image

After image

Before image

After image

gkjohnson commented 4 months ago

Rolling back to the old viewer models still shows these issues so something meaningful changed:

https://github.com/gkjohnson/three-gpu-pathtracer/tree/old-viewer-models

gkjohnson commented 4 months ago

v0.0.13 seems to work as the original images while v0.0.14 not - for the suzanne model, at least.

gkjohnson commented 4 months ago

Looks like this change happened in #397

gkjohnson commented 4 months ago

Change happened specifically in c611a95 for suzanne iridesence

gkjohnson commented 4 months ago

And the roughness issue is caused by 1fefaebab87e20efba56c10993ae004156f45101