search

gkjohnson / three-gpu-pathtracer

Path tracing renderer and utilities for three.js built on top of three-mesh-bvh.
https://gkjohnson.github.io/three-gpu-pathtracer/example/bundle/index.html
MIT License
1.27k stars 125 forks source link

Remove threeCompatibilityTransforms #549

Closed mrdoob closed 4 months ago

mrdoob commented 4 months ago

I think these can be removed now?

https://github.com/gkjohnson/three-gpu-pathtracer/blob/0b9ffc9f8deb1d3bcbb58acbf6e5b75c0a13f491/README.md?plain=1#L808-L816

https://github.com/gkjohnson/three-gpu-pathtracer/blob/0b9ffc9f8deb1d3bcbb58acbf6e5b75c0a13f491/src/uniforms/MaterialsTexture.js#L120-L160

gkjohnson commented 4 months ago

Oh is this fixed? Nice! So every texture will use it's own transform matrix in three.js, now?

gkjohnson commented 4 months ago

@mrdoob Do you recall which version of three.js this was fixed in? I'll want to update the minimum peer dependency.

mrdoob commented 4 months ago

It was r151. https://github.com/mrdoob/three.js/pull/25721#issuecomment-1487170206