gkjohnson / three-gpu-pathtracer

Path tracing renderer and utilities for three.js built on top of three-mesh-bvh.
https://gkjohnson.github.io/three-gpu-pathtracer/example/bundle/index.html
MIT License
1.27k stars 125 forks source link

PathTracingSceneWorker: Adjust API to match DynamicPathTracingSceneGenerator #569

Closed gkjohnson closed 3 months ago

gkjohnson commented 3 months ago

Ie pass items into constructor and generate takes no arguments. Could possibly just extend the Dynamic variant.

gkjohnson commented 3 months ago

We can remove PathTracingSceneWorker and replace with Dynamic generator. We can also rename DynamicPathTracingSceneGenerator to PathTracingSceneGenerator.

gkjohnson commented 3 months ago

Related to #571 fixed in https://github.com/gkjohnson/three-gpu-pathtracer/commit/f55cc66144e1fc18f4355e2427e9aa842c4a3816