search

gkjohnson / three-gpu-pathtracer

Path tracing renderer and utilities for three.js built on top of three-mesh-bvh.
https://gkjohnson.github.io/three-gpu-pathtracer/example/bundle/index.html
MIT License
1.27k stars 125 forks source link

Test on browsers, devices #622

Closed gkjohnson closed 2 months ago

gkjohnson commented 2 months ago

Safari, Firefox, chrome iOS, Android

gkjohnson commented 2 months ago

Android seems to fail when using the new random sampling system.'

edit Sampling the offset texture every sample seems to fix this?

Addressed in 8f0687c

robertoranon commented 2 months ago

Did some testing (not example by example, but most of them) on macOS M1 Max with Safari (17.4.1), Chrome (123.0.6312.107) and Firefox (124.0.1): all working great (much quicker startup than the last time I tried - what did you do? 😀)

Tested also most examples on iOS 17.3.1 (iPhone 13): all ok. Do you want me to test something specific?

gkjohnson commented 2 months ago

No I just wanted to make sure it worked on these devices and we didn't have regressions on some of the iOS fixes you made previously. Thanks for checking!

gkjohnson commented 2 months ago

all working great (much quicker startup than the last time I tried - what did you do? 😀)

Ha not sure. The geometry preprocessing may be a bit faster, now, and most of the demos now use asynchronous BVH building. It could be a combination of those?