gkjohnson / three-gpu-pathtracer

Path tracing renderer and utilities for three.js built on top of three-mesh-bvh.
https://gkjohnson.github.io/three-gpu-pathtracer/example/bundle/index.html
MIT License
1.27k stars 125 forks source link

SheenWoodLeatherSofa renders incorrectly #641

Open mrdoob opened 1 month ago

mrdoob commented 1 month ago

Describe the bug

This new assets renders incorrectly:

https://github.com/KhronosGroup/glTF-Sample-Assets/pull/123

https://github.com/KhronosGroup/glTF-Sample-Assets/blob/e51c108880863c3d1ee161341a0d834a9152278c/Models/SheenWoodLeatherSofa/glTF-Binary/SheenWoodLeatherSofa.glb

Screenshots and Repro Model

Screenshot 2024-05-23 at 10 48 05 AM

Screenshot 2024-05-23 at 10 47 49 AM

dongho-shin commented 5 days ago

FYI)it looks fine in my mac

image

i try in three.js editor with royal_esplanade_1k.hdr background, environment

gkjohnson commented 4 days ago

@mrdoob - I'm not seeing the issue, either. Can you reproduce it? What kind of lighting setup were you using?

Here's what it looks like with some directional lights:

image
dongho-shin commented 5 hours ago

I check in index(default example), it occasionally reproduces

add this into window.MODEL_LIST

'SheenWoodLeatherSofa': {
    url:'https://raw.githubusercontent.com/KhronosGroup/glTF-Sample-Assets/SheenWoodLeatherSofa/Models/SheenWoodLeatherSofa/glTF-Binary/SheenWoodLeatherSofa.glb',
    credit: 'glTF Sample Model.',
},
gkjohnson commented 46 minutes ago

Here's the corrected file url that worked for me:

https://raw.githubusercontent.com/KhronosGroup/glTF-Sample-Assets/e51c108880863c3d1ee161341a0d834a9152278c/Models/SheenWoodLeatherSofa/glTF-Binary/SheenWoodLeatherSofa.glb

I check in index(default example), it occasionally reproduces

Interesting - in addition to textures sometimes not working I'm seeing that an error is occasionally hit when building the merged geometry, which is odd. I wonder if there's some kind of loading race condition here? This will need a bit more digging.