gkjohnson / urdf-loaders

URDF Loaders for Unity and THREE.js with example ATHLETE URDF Files open sourced from NASA JPL
https://gkjohnson.github.io/urdf-loaders/javascript/example/bundle/index.html
Apache License 2.0
442 stars 113 forks source link

Console warning is emitted every time you try to set a mimic joint's values #252

Closed EzraBrooks closed 1 year ago

EzraBrooks commented 1 year ago

There are a number of systems and drivers that emit mimic joints' values, even though they are unnecessary, and there are even some systems that don't support mimic joints at all (like, last I checked, NVIDIA Isaac Sim) which make publishing the mimic joint status necessary.

As a result, the software I work on publishes mimic joints values, deliberately. Unfortunately with urdf-loaders this floods the console with warnings! Would it be okay if I submitted a PR to remove this console.warn call?

gkjohnson commented 1 year ago

Yup! Makes sense -- feel free to make a PR.