search

gkjohnson / urdf-loaders

URDF Loaders for Unity and THREE.js with example ATHLETE URDF Files open sourced from NASA JPL
https://gkjohnson.github.io/urdf-loaders/javascript/example/bundle/index.html
Apache License 2.0
471 stars 122 forks source link

added mimic joint support and mapping + additional features #288

Closed robit-man closed 5 months ago

robit-man commented 6 months ago
  1. Added full support for mimic joint functionality, bi-directional mapping of dependents to master joint
  2. Added case for mimic joint dependents to slider controls.
  3. Added up axis listener to urdf list
  4. Added example urdf for mimic example
  5. Added minor styling changes to handle new additions
  6. Minor syntax corrections and removal of whitespace

https://github.com/gkjohnson/urdf-loaders/assets/36677806/8eda4b96-7570-4334-9f6b-b78d358e49a4

robit-man commented 6 months ago

Ignore commits after 4b2ecb8

gkjohnson commented 6 months ago

Hello! Thank you for the contribution. Unfortunately this PR is too large to be reviewed and merged as it is, though. It would be best to submit small PRs for individual fixes and additions. And ideally we'd be able to discuss what you want to achieve in an issue, first, so we can make sure it's something that makes sense to add into the project, as well.

Is there any more context for the creation of this PR?