gklyne / admiral-jiscmrd

Automatically exported from code.google.com/p/admiral-jiscmrd
MIT License
0 stars 0 forks source link

Python files containing embedded silo name #29

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
SubmitDatasetConfirmationHandler.py
SubmitDatasetSummaryHandler.py

Have the "admiral-test" silo name embedded in the code.

This is problematic because this code cannot be deployed to systems that use a 
different silo name, and
is inconsistent because in some cases silo names are selected in Javascript 
code, and in these cases
it is the Python code that makes the selection.

It's not clear what is the best solution to this.  One possible fix would be to 
make the silo name part
of the form data returned when selecting/confirming a dataset, where it can be 
obtained from /var/www/admiral-cpnfig.js via Javascript code that initializes 
the form data.

Another would be to access a config file on the ADMIRAL host.

There are other possible solutions...

Original issue reported on code.google.com by gk-goo...@ninebynine.org on 2 Mar 2011 at 5:13

GoogleCodeExporter commented 8 years ago

Original comment by gk-goo...@ninebynine.org on 2 Mar 2011 at 5:14

GoogleCodeExporter commented 8 years ago
Another option would be a python configuration file, maybe in a directory 
outside the /data/tool area, but this would still be another file to be 
maintained.  Unless it can read and extract values from the javascript file...?

Original comment by gk-goo...@ninebynine.org on 2 Mar 2011 at 5:17

GoogleCodeExporter commented 8 years ago
Partial fix: SubmitDatasetSummaryHandler.py does not use siloName value, so 
assignment deleted.

Original comment by gk-goo...@ninebynine.org on 2 Mar 2011 at 5:33

GoogleCodeExporter commented 8 years ago
Another option would be to use a standard paty for databank access, and rely on 
the Apche proxy configuration to route it.

Original comment by gk-goo...@ninebynine.org on 2 Mar 2011 at 5:34

GoogleCodeExporter commented 8 years ago

Original comment by bhavana....@gmail.com on 3 Mar 2011 at 4:33

GoogleCodeExporter commented 8 years ago
Missed reference to silo name in SubmitDatasetConfirmationHandler.py

Original comment by gk-goo...@ninebynine.org on 31 Mar 2011 at 1:43

GoogleCodeExporter commented 8 years ago
Reference to the siloname in SubmitDatasetConfirmationHandler.py was changed to 
/databanksilo/. Using this the session._endpointpath was formulated.

Also modified the databank-proxy configuration to proxy to the selected 
databank-silo when a request is made as: /databanksilo

Original comment by bhavana....@gmail.com on 31 Mar 2011 at 2:14