search

gklyne / milarq

Automatically exported from code.google.com/p/milarq
0 stars 0 forks source link

genericIndex.java doesn't close reader #1

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Observed by code review.

Anonymous inner class:

        return new QueryIterator() 
            {
            BufferedReader in = inFromFile( indexFullName );
            :
            }

Uses 'in' but never closes it, or its associated open file.

Original issue reported on code.google.com by gk-goo...@ninebynine.org on 27 Aug 2010 at 2:31

GoogleCodeExporter commented 9 years ago 
File

http://code.google.com/p/milarq/source/browse/src/propertyfunctions/genericIndex
.java

Line 64, et seq.

Original comment by gk-goo...@ninebynine.org on 27 Aug 2010 at 2:34

GoogleCodeExporter commented 9 years ago 
Fixed -- close reader on explicit close() or reading the last element.

Original comment by ehog.he...@googlemail.com on 17 Sep 2010 at 8:36