gkngkc / UnityStandaloneFileBrowser

A native file browser for unity standalone platforms
MIT License
2.01k stars 317 forks source link

Fix Standalone Builds for Unity 2019.3 #76

Open rubenwe opened 4 years ago

rubenwe commented 4 years ago

This should fix #69, #73 and maybe #71.

I used the Dlls from the mono/4.5 folder of Unity. Builds again on Windowsx64 with Mono and IL2CPP.

Suyashtnt commented 4 years ago

how do you install these changes?

Suyashtnt commented 4 years ago

ok, i figured how to but when I build in Windows64 it does not display "open folder" like how I want it to, any fix for this?

rubenwe commented 4 years ago

@Suyashtnt I don't get what exactly you are asking for. If you give a little more context I might be able to help. At least in my project the FolderBrowser-Dialog works with those changes on Windows 64bit Mono and IL2CPP builds.

sergiosolorzano commented 4 years ago

Hi @rubenwe Thanks a bunch for your guidance. I can't build for win or mac il2cpp.

Can you please clarify, when you say you use the dlls for mono/4.5 , what assets/plugins folder setup we should have please?

I can't build for win or macosx

My windows settings:

I also tried with all systems (win, macosx, linux) ticked for standalone settings of each dll at the time of build.

Failed running C:\Program Files\Unity\Hub\Editor\2019.3.13f1\Editor\Data\il2cpp/build/deploy/net471/il2cpp.exe --convert-to-cpp --emit-null-checks --enable-array-bounds-check --dotnetprofile="unityaot" --compile-cpp --libil2cpp-static --platform="WindowsDesktop" --architecture="x64" --configuration="ReleasePlus" --outputpath="drive:unityproject\Temp/StagingArea/Data\Native\GameAssembly.dll" --cachedirectory="drive:unityproject\Assets..\Library/il2cpp_cache" --incremental-g-c-time-slice=3 --profiler-report --map-file-parser="C:/Program Files/Unity/Hub/Editor/2019.3.13f1/Editor/Data/Tools/MapFileParser/MapFileParser.exe" --directory=drive:unityproject\/Temp/StagingArea/Data/Managed --generatedcppdir=drive:unityproject\/Temp/StagingArea/Data/il2cppOutput

Exception: C:\Program Files\Unity\Hub\Editor\2019.3.13f1\Editor\Data\il2cpp/build/deploy/net471/il2cpp.exe did not run properly!

thanks a bunch !

rubenwe commented 4 years ago

@sergiosolorzano what I meant by that is that the DLLs I included in this PR are from the Unity installation - they are the mono/4.5 ones from \Editor\Data\MonoBleedingEdge\lib\mono\4.5.

If you want to compare settings you can check out https://github.com/rubenwe/stlvault (requires GIT LFS - see DEVELOPMENT.md). That one builds and works on all OSes with IL2Cpp.

shinkuan commented 4 years ago

My project successfully built. But when I try to open a folder, it doesn't, and there is no error show up, just nothing happen. How do I fix this?

shadowfox87 commented 3 years ago

Will using the dlls from mono/4.5 also allow you to build for Windows x86? Or only 64-bit?

chaoslife commented 3 years ago

does it support .net standard2.0 ? @rubenwe

rubenwe commented 3 years ago

@chaoslife depends on what you mean by that. The assemblies are taken from the mono runtime, so they probably don't target .netstandard2.0.

That doesn't mean that this wil cause issue if you select .netstandard2.0 backend. As far as I understand it, in the end you can't be running on .netstandard anyways. You need a concrete runtime and that can be compatible to the standard.

IL2CPP generated output seems to be compatible and the Mono runtime should be too, as the binaries are taken from it.

Thane5 commented 3 years ago

My project successfully built. But when I try to open a folder, it doesn't, and there is no error show up, just nothing happen. How do I fix this?

I'm having the same issue after trying this fix. It builds properly, but then the file window never opens.

Edit: Nevermind, switching to .Net 4.x solved it

Dummiesman commented 2 months ago

Also appears to fix #136