search

gkoberger / BugzillaJS

A userscript that adds additional functionality to bugzilla
https://addons.mozilla.org/en-US/firefox/addon/bugzillajs/
43 stars 18 forks source link

'Highlight reporter and assignee comments' feature is broken #105

Closed rik closed 9 years ago

rik commented 9 years ago

No one reported it so it's probably not used a lot. But it should also be a simple fix because the DOM selections are not matching anymore.

darkred commented 7 years ago

I've noticed that the feature is broken (current version 3.5.0).

yfdyh000 commented 7 years ago

@darkred it is works for me.

darkred commented 7 years ago

@yfdyh000 I'm using Firefox 49.0.2 x64 in win10. Could you please provide a screenshot showing the feature? Because, e.g. in this bug I've reported: I can't spot any difference to my comment (comment 2) to e.g. comment 1: screenshot

yfdyh000 commented 7 years ago

@darkred In that bug, the reporter is comment 0: Kostas(reporter) 0 years, 11 months ago. 2016-11-03 05 43 01

darkred commented 7 years ago

Thanks. Yes, the reporter is me. So, apart from my comment 0, shouldn't my following comments (comment 2) also be highlighted in green?

yfdyh000 commented 7 years ago

I think the background color is highlighted for the hierarchy, not for the reporter identity. 2016-11-03 05 49 02

darkred commented 7 years ago

Ok, then the feature is not working at all for me, because, as you may see in my screenshot, there's no (reporter) next to my name in comments 0 or 2.

I also tested it in a fresh FF 49.0.2 x64 profile too (win 10) with only BugzillaJS installed.

yfdyh000 commented 7 years ago

That's it, only comment 0 is the green background. The Highlight feature just annotation like the "(reporter)", and turning off this feature does not affect the background colors.

Do you have checked this option in "BugzillaJS Preferences" (It's on the page)?

darkred commented 7 years ago

Do you have checked this option in "BugzillaJS Preferences" (It's on the page)?

Yes, of course. (and, this option is enabled by default when installing BugzillaJS) 2016-11-03_000430 I haven't modified any setting, except enabling the (currently broken) keyboard shortcuts. (but, disabling that didn't help either)

yfdyh000 commented 7 years ago

Well, I have not encountered this problem so far. Fx50b11 x64 on Win10 x64.

darkred commented 7 years ago

I tested it with Firefox 49.0 x64 stable, 50 beta RC1 x64 beta , Nightly 52 x64 (on Win10 x64) each time on a fresh profile with only BugzillaJS installed and the feature doesn't work in either of them.

darkred commented 7 years ago

Well, I have not encountered this problem so far. Fx50b11 x64 on Win10 x64.

@yfdyh000, as you may see in my last post, I have tried all these FF versions, and even tried previous BugzillaJS versions (the 5 most recent) always with a clean FF profile and with BugzillaJS having its default settings. and it doesn't work in any case.

It's very strange that it works for you. Could you please try it in a clean FF profile with only BugzillaJS?

yfdyh000 commented 7 years ago

@darkred I still see it working with a new profile, Fx50.0 x64, BugzillaJS 3.5.0, after login (When not logged in, I can not find BugzillaJS), including Dusk or Mozilla skin. with https://bugzilla.mozilla.org/show_bug.cgi?id=100002: 2016-11-12 23 26 58 2016-11-12 23 27 05 with https://bugzilla.mozilla.org/show_bug.cgi?id=1227094: 2016-11-12 23 28 24

Maybe your Bugzilla account settings affect it? Change an account and try again may be useful.

darkred commented 7 years ago

Thanks for testing.

I checked all the settings in my Bugzilla account and all are left to default (apart from the timezone).

And, I created another Bugzilla account as you suggested, and tested it with BugzillaJS 3.5.0 in both FF 49 and 50 with FF fresh profiles, having login with that new account, and unfortunately it doesn't work in any case.

It's so strange that it works for you.

darkred commented 7 years ago

Just for reference: I tried tweaking my Bugzilla account prefs (all of which had their default values). and I found that the highlight feature may work only if I set Use experimental user interface to on. But then. the relative timestamps are different than before: e.g. for https://bugzilla.mozilla.org/show_bug.cgi?id=1227094 comment 0 now is a year ago (instead of 0 years, 11 months ago).

darkred commented 7 years ago

@yfdyh000 What if I uploaded the .htm of e.g. the last bugzilla link, would it be of any use to you? I mean, would it be useful to you to diff my .html saved file (in a fresh FF 50 profile, with only BugzillaJS installed, having login to my bugzilla account) with an .htm that you'll save, in order to spot any differences in the HTML code that might be causing this issue?

I can't think of any other reason why it doesn't work for me.

yfdyh000 commented 7 years ago

@darkred A good news: I have been able to reproduce the problem with a new account. But bad news: It appears that this feature require you to have permission to edit the assignee field. https://developer.mozilla.org/en-US/docs/Mozilla/Bugzilla/What_to_do_and_what_not_to_do_in_Bugzilla#Getting.2FUpgrading_Bugzilla_privileges is enough.

Because there is no active maintainers, so I didn't study how to fix the problem on the source code. https://github.com/gkoberger/BugzillaJS/search?q=bz_assignee_edit_container

And because https://blog.mozilla.org/addons/2016/11/23/add-ons-in-2017, if anyone interested to porting this extension to WebExtensions, I have a demo: https://github.com/yfdyh000/BugzillaJS/commits/WebExtension.

darkred commented 7 years ago

@yfdyh000 Thanks for testing.

So I have made this pull request https://github.com/gkoberger/BugzillaJS/pull/125. I hope you agree with my suggested changes.