search

gkoberger / BugzillaJS

A userscript that adds additional functionality to bugzilla
https://addons.mozilla.org/en-US/firefox/addon/bugzillajs/
43 stars 18 forks source link

Fix things to work with the new UI #126

Closed mrbkap closed 7 years ago

mrbkap commented 7 years ago

The new bugzilla "modal" UI changes a few IDs and CSS classes. This changeset makes BugzillaJS aware of them.

Note: I've done some light testing to make sure that these changes work in both the new and old UIs; however, I can't say I've been exhaustive. That being said, the only feature I really care about is having inline treeherder logs. Given that, if there are any concerns about other parts of this patch, I would appreciate being able to push at least that change (which I have tested to work in both configurations).

mrbkap commented 7 years ago

I also noticed that a bunch of stuff provided by the addon has slowly migrated into Bugzilla proper (such as marking comments by the reporter or assignee as such above each comment). That might allow someone to simplify the addon somewhat and get rid of redundant features.

mnoorenberghe commented 7 years ago

Note: I've done some light testing to make sure that these changes work in both the new and old UIs

Did you also test with stock Bugzilla (not BMO)?

I also noticed that a bunch of stuff provided by the addon has slowly migrated into Bugzilla proper (such as marking comments by the reporter or assignee as such above each comment)

Yeah, a lot of things are in BMO but not as many are in Bugzilla proper last I looked. It's hard to tell since last I checked there was not landfill/demo site of Bugzilla trunk anymore. My main problem with maintaining this extension is supporting non-BMO installs (especially since there isn't a stock Bugzilla test site) but I don't have the time to even figure out the impact of that unfortunately.

mrbkap commented 7 years ago

Did you also test with stock Bugzilla (not BMO)?

I haven't. I'll do a quick test to check tomorrow. I don't think that these changes could break anything that used to work, though, since I think they should all select exactly the old element + the new ones (that is, any element that would have been selected before will still be selected; but we will select these new classes).

mrbkap commented 7 years ago

I've confirmed that the extension still works on landfill. While testing there, I found some bugs that I'm not going to bother to fix related to the extension assuming that the user is logged in (and that everybody who comments or reports bugs has a real name).

mnoorenberghe commented 7 years ago

Thanks!

mnoorenberghe commented 7 years ago

Version 3.6.0 has just been approved on AMO: https://addons.mozilla.org/addon/bugzillajs/