Closed sethfowler closed 11 years ago
rik
commented
11 years ago I'm wondering if everyone would like this option. This would make reading all comments more difficult, you'd have to scroll a lot more. I'm not looking at a lot of bugs with TBPL so I have no preference, just pointing this out.
@bgirard Since you did the original implementation, what do you think?
rik
commented
11 years ago Another option would be to only expand the iframe when you focus it. Could that be a good tradeoff?
bgirard
commented
11 years ago I don't object to make them taller. I personally open the link in a new tab when I need to interact with it. My goals was just to see the results at a glance when scrolling the bug rather then providing a full functional TBPL embedding.
sethfowler
commented
11 years ago Yeah, I certainly am not saying I want to use TBPL through the iframe or anything. =) I was just hoping to be able to see the results for more platforms at a glance. I am sometimes testing on 10 or more platforms at once and only a few of them fit. I would be cool with the iframe expanding on focus, too - in fact I think that's a great idea! - but I still think they could benefit from being a little taller by default as well.
rik
commented
11 years ago A good page to test once implemented. https://bugzilla.mozilla.org/show_bug.cgi?id=842841
rik
commented
11 years ago So I've changed the default height to 200px and the focused height is 600px.
You can test at http://ricaud.me/tmp/bugzillajs.xpi. Tell me what you think.
I really like the embedded Try results pages you've added, but they don't fit very nicely vertically. I'd prefer for there to be no scrollbar so that I can see all of the results at a glance.