Closed mikedeboer closed 5 years ago
@Rik I merged in gkoberger/omnium#3, so this is good to go. Of course it's up to you if you want to include it, but it seems like some really awesome changes.
Assuming it works (I haven't actually tested it thoroughly), there's a few major features that I'm excited about:
Sorry for letting this idle for so long. Markdown support is coming to Bugzilla so I don't want to interfere with that (because we need to modify comments for this markdown support).
The demo page and the EventEmitter are pretty cool. Would be nice to get this part in. It's not very fair to ask after letting this unanswered for so long but it would be cool if you could prepare a pull request for those.
Actually, maybe we can use the new Bugzilla tagging system to get this in without disturbing people too much? What do you think @globau ?
i think that introducing markdown here may be problematic, especially if it isn't 100% compatible with bugzilla's native markdown support (we have modified git-flavoured markdown). as soon as it's ready upstream we'll be backporting to to bmo.
my preference for this extension is for it not to include markdown, and for that effort to instead be directed into finishing up the few remaining issues with bugzilla-native markdown, making it available to all bugzilla users.
@gkoberger : Can't we just land this until support is added to Bugzilla? Especially considering that nothing seems to have happened for over a year on the Bugzilla side.
@MikeRatcliffe that is not true at all. markdown support has landed upstream, and BMO will upgrade to a version that supports markdown soon (currently in final testing phase).
Markdown is now on BMO
Since I believe there's a bright future ahead for this addon, I went ahead and readied some more things for that future. I'll provide more comments in the code.
This PR depends on gkoberger/omnium#3
I didn't know directly where to put this, so I'll leave it up to you: