gkoberger / BugzillaJS

A userscript that adds additional functionality to bugzilla
https://addons.mozilla.org/en-US/firefox/addon/bugzillajs/
43 stars 18 forks source link

Cannot build a clean checkout for `-t jetpack` #85

Closed lonnen closed 11 years ago

lonnen commented 11 years ago

I can't seem to build a fresh checkout. I follow the README and the build cannot find bin/activate -- do I need to setup jetpack or something?

$ ./builder.js -t jetpack bugzillajs/
GENERATING JETPACK SCRIPT
    Copying scripts...
    + omnium_bootstrap.js
    + omnium_bootstrap.js
    + jquery.js
    + jsonp.js
    + jquery.scrollTo.js
    + jquery.flot.js
    + jquery.flot.pie.js
    + md5.js
    + bugzilla-defs.js
    + bugzilla.js
    + bugzilla-date.js
    + bugzilla-images.js
    + bugzilla-hidenobody.js
    + bugzilla-listingpage.js
    + bugzilla-git.js
    + bugzilla-gravatars.js
    + bugzilla-comments.js
    + bugzilla-misc.js
    + bugzilla-agile.js
    + bugzilla-keyboard.js
    + bugzilla-tbpl.js
    + omnium_combined.css
    Creating basic build files...
    + package.json
    + main.js

/Users/lonnen/repos/omnium/builder.js:407
            throw err;
                  ^
Error: Command failed: /bin/sh: bin/activate: No such file or directory

    at ChildProcess.exithandler (child_process.js:632:15)
    at ChildProcess.EventEmitter.emit (events.js:98:17)
    at maybeClose (child_process.js:730:16)
    at Socket.<anonymous> (child_process.js:943:11)
    at Socket.EventEmitter.emit (events.js:95:17)
    at Pipe.close (net.js:451:12)
gkoberger commented 11 years ago

In theory, it should do everything for you. Someone else just rewrote gkoberger/omnium (which is used to build the add-ons), so I'm not sure exactly how it works anymore -- but I just tried building it and it worked for me.

The builder sdk should be in .builder/jetpack-sdk. Try cding there, and running:

source bin/activate
cfx xpi --pkgdir='_bugzillajs'

Does _bugzillajs folder exist there? Can you build it manually using the command above? Maybe you didn't check things out recursively?

gkoberger commented 11 years ago

Another possibility is that the sdk_dir is being set wrong. After line 302 in builder.js, try doing console.log(sdk_dir)? Maybe the code (var sdk_dir = Path.join(__dirname, ".builder", "jetpack-sdk");) is using the wrong __dirname or something?

lonnen commented 11 years ago

the sdk was missing from .builder/jetpack-sdk, so I blew everything away and redownloaded it using exactly what's in the readme. Everything works now. Thanks!