search

gkoberger / BugzillaJS

A userscript that adds additional functionality to bugzilla
https://addons.mozilla.org/en-US/firefox/addon/bugzillajs/
43 stars 18 forks source link

BugzillaJS prevents good anchor links with Sandstone theme #86

Closed rik closed 11 years ago

rik commented 11 years ago

As of https://bugzilla.mozilla.org/show_bug.cgi?id=848455, the Sandstone theme behaves properly with anchor links and the fixed header.

But BugzillaJS breaks it!

KWierso commented 11 years ago

It only seems to break with the the "Style the Comments" preference in Bugzilla.js enabled.

KWierso commented 11 years ago

Looks like that preference controls things starting at line 31 of https://github.com/gkoberger/BugzillaJS/blob/master/includes/bugzilla.js

function addStyling() { if (settings['gitcomments']) { $('body').addClass('git_style') $('.git_style .ih_history br').replaceWith("; "); setTimeout(repositionScroll, 200); } }

function repositionScroll() { //-- Reposition the scrollTo if necessary if(location.hash.match(/#c[0-9]*/)) { $(window).scrollTo($(location.hash)); } }

rik commented 11 years ago

I'm gonna close this since Sandstone removed the fixed header for now.

I'll watch https://bugzilla.mozilla.org/show_bug.cgi?id=905763.