search

gkoberger / BugzillaJS

A userscript that adds additional functionality to bugzilla
https://addons.mozilla.org/en-US/firefox/addon/bugzillajs/
43 stars 18 forks source link

Add cmd-enter keyboard shortuct for submitting comments. #90

Closed pmclanahan closed 10 years ago

pmclanahan commented 11 years ago

I'm not fully pleased with how this is done, but it does work. There should probably be a better shortcut menu display that will show the correct thing for the OS (e.g. cmd for OSX), and it'd be cleaner if the shortcut stuff were refactored to allow for meta key combinations in the normal callbacks.

The idea is from https://github.com/dewski/cmd-enter

pmclanahan commented 11 years ago

@Rik let me know what you think.

rik commented 11 years ago

Sorry, I'm all busy at a work week, will take a look next week.

pmclanahan commented 11 years ago

No worries. Thanks for looking at it.

pmclanahan commented 10 years ago

Bump

pmclanahan commented 10 years ago

@Rik still working on this project? Who else should I ping if you're swamped?

rik commented 10 years ago

OK, "next week" was a bit of a lie, wasn't it? I just saw you opened https://bugzilla.mozilla.org/show_bug.cgi?id=1009716 and I'd prefer if Bugzilla implemented this directly.

My current plan is to phase out most of BugzillaJS because we have an active team working on BMO now. So we should try and get this inside Bugzilla directly. I opened a similar one 2 months ago and it was almost shipped! https://bugzilla.mozilla.org/show_bug.cgi?id=984980

pmclanahan commented 10 years ago

Agreed. Sounds good. Thanks.

Sent from my mobile. Please excuse my brevity.