search

gkonovalov / android-vad

Android Voice Activity Detection (VAD) library. Supports WebRTC VAD GMM, Silero VAD DNN, Yamnet VAD DNN models.
MIT License
259 stars 59 forks source link

Does yamnet not need proguard? #19

Closed developerzjy closed 1 year ago

developerzjy commented 1 year ago

I am not using any proguard for yamnet, and no problems were found in my app release version. But I'm not sure if there's a hidden problem.

gkonovalov commented 1 year ago

I would like to avoid using Proguard for open source library:

Application projects obfuscate the entire code base, including any referenced libraries, so they need proper configuration for the application code and for the library code. In such cases, ProGuard settings are typically handled at the application level to ensure the correct obfuscation of both the app and its dependencies.