search

gkopff / gson-javatime-serialisers

A set of GSON serialiser/deserialisers for dealing with Java 8 java.time entities.
MIT License
87 stars 19 forks source link

Add InstantConverter to Converters #14

Closed mwanji closed 9 years ago

mwanji commented 9 years ago

I was trying to use the library in a project and realised I'd forgotten to add the InstantConverter to Converters.registerAll()... Sorry!

Also, I added 2 tests to ConvertersTest that actually fail if the converters are not registered. That was not the case for any of the existing tests. I modified InstantConverterTest as an example of how the other tests could be modified to fail if the Converter is not registered. However, it's not strictly necessary, as I believe ConvertersTest now covers all cases: serialising and deserialising.

mwanji commented 9 years ago

Thanks! Again, I apologise for forgetting to do this initially.

mwanji commented 9 years ago

Would it be possible to create a new release with this PR?

gkopff commented 9 years ago

Yes give me two days.

Sent from my iPhone

On 21 Jan 2015, at 8:25 am, Moandji Ezana notifications@github.com wrote:

Would it be possible to create a new release with this PR?

— Reply to this email directly or view it on GitHub.

mwanji commented 9 years ago

Great, thanks.

gkopff commented 9 years ago

Released. May take a few hours to propagate.

mwanji commented 9 years ago

Thank you!