search

gkreitz / homeassistant-grohe_sense

Grohe Sense integration for Home Assistant
MIT License
42 stars 25 forks source link

Suggestion to change unit for water pressure #13

Open pertakman opened 3 years ago

pertakman commented 3 years ago

Thank you for the hard work you've put into making this custom integration!

I've been using it ever since you finished the switch to turn off the water when nobody is at home. It works great based on cell phone presence and security alarm state.

I had to upgrade to latest version yesterday when I upgraded Home Assistant. I realized today that you've added units to the pressure, but that you've chosen mbar instead of bar. It seems to me like bar is a more common unit for water pressure rather than mbar. I've changed the sensor.py file in my system manually to set it back to bar. If you think this makes sense you could change on your side as well.

Please disregard if mbar makes more sense to you!

Warmly, Per

zuper83 commented 2 years ago

Thank you for the hard work you've put into making this custom integration!

I've been using it ever since you finished the switch to turn off the water when nobody is at home. It works great based on cell phone presence and security alarm state.

I had to upgrade to latest version yesterday when I upgraded Home Assistant. I realized today that you've added units to the pressure, but that you've chosen mbar instead of bar. It seems to me like bar is a more common unit for water pressure rather than mbar. I've changed the sensor.py file in my system manually to set it back to bar. If you think this makes sense you could change on your side as well.

Please disregard if mbar makes more sense to you!

Warmly, Per

Per, may I friendly ask what changes you did in sensor.py to revert back to bar? I'm not so skilled. Best regards Markus

pertakman commented 2 years ago

Hi Markus,

The file names sensor.py contains two occurrences the text "PRESSURE_MBAR". I simply replaced it with "PRESSURE_BAR". That works for me!

I've attached my modified version of the file.

Cheers, Per

sensor.zip

zuper83 commented 2 years ago

Great feedback, now implemented and it works. Thanks!

Hi Markus,

The file names sensor.py contains two occurrences the text "PRESSURE_MBAR". I simply replaced it with "PRESSURE_BAR". That works for me!

Cheers, Per