search

gkrid / dokuwiki-plugin-approve

GNU General Public License v2.0
4 stars 17 forks source link

Missing id value in approve button link on the diff page #14

Closed outrelouxhe closed 5 years ago

outrelouxhe commented 5 years ago

The link activated by the "Approve" button at the bottom of the diff page (which is shown before we really can approve a page) has an empty ID, like the following example :

https://server_address/doku.php?id=&approve=approve

When debugging the code in approve.php on line 34, the $_GET variable doesn't include the 'id' value on my pages. This is strange as this section hasn't been updated in the last revision. I had previously installed then removed the "publish" plugin. Could that be a reason ?

Thank you in advance for your feedback.

Regards,

Frédéric

outrelouxhe commented 5 years ago

Found the cause : in my config the 'userewrite' parameter was set to 'Dokuwiki internal' which makes the id parameter doesn't exist. I changed the code to use $ID instead of $_GET['id] and then it works again. Thank you.