gkz / LiveScript

LiveScript is a language which compiles to JavaScript. It has a straightforward mapping to JavaScript and allows you to write expressive code devoid of repetitive boilerplate. While LiveScript adds many features to assist in functional style programming, it also has many improvements for object oriented and imperative programming.
http://livescript.net
MIT License
2.32k stars 155 forks source link

RFC: support compiler warnings in a less ad-hoc way #1001

Closed rhendric closed 6 years ago

rhendric commented 6 years ago

Since #987 got blocked on a compiler warning, but I wanted to write tests that would trigger that warning, I decided we should make compiler warnings more of a thing, largely so they could be disabled in tests (or other situations where they need to be disabled).

This of course opens the gates to more compiler warnings being used in more places where we want to eventually break compatibility or ensure that dumb things don't happen (see: #1000).

However, even though this is a small amount of code, it's adding a compiler flag which I think of as a big change. Want to get lots of feedback on this before I merge it.

vendethiel commented 6 years ago

We really need to cleanup the divide between a or EXPR and EXPR unless a (and/if as well). Postfix unless-es like this tend to be hard to notice.

I agree with the sentiment, more generally.