search

gkz / LiveScript

LiveScript is a language which compiles to JavaScript. It has a straightforward mapping to JavaScript and allows you to write expressive code devoid of repetitive boilerplate. While LiveScript adds many features to assist in functional style programming, it also has many improvements for object oriented and imperative programming.
http://livescript.net
MIT License
2.32k stars 155 forks source link

Fix for #897 #1066

Closed pepkin88 closed 6 years ago

pepkin88 commented 6 years ago

Fix for #897

os.homedir was added in Node v2.3.0, fallback values of process.env.HOME and process.env.USERPROFILE works for POSIX and Windows

rhendric commented 6 years ago

This looks good to me, but I'd like a second person to test this on Windows (I assume you did?) just to be sure (and to ensure there are no lurking second bugs hiding behind the one you fixed).

vendethiel commented 6 years ago

Works on my windows

pepkin88 commented 6 years ago

Yes, I checked both os.homedir! and process.env.USERPROFILE. Windows is my main platform, although I do tests and builds on a virtual Ubuntu machine.