search

gkz / grasp

JavaScript structural search, replace, and refactor
http://graspjs.com
MIT License
1.28k stars 33 forks source link

extract filter from replace #111

Open kristianmandrup opened 7 years ago

kristianmandrup commented 7 years ago

Please help extract filter from replace (PR not to working, but clearly shows intent)

Currently the code is extremely "poor" and very hard to "grasp" as too much is "bundled together". Please divide and conquer so we can have Single Responsibility. Thanks ;)

PS: I used to do a lot of LiveScript, but been a while...

kristianmandrup commented 7 years ago

Also, please do some documentation of the internal architecture :)

gkz commented 7 years ago

Yeah, might not merge this exact diff, but I should factor this out you're right

kristianmandrup commented 7 years ago

Perhaps you could instead help me on my branch. I did a lot of work on refactoring alrwady