search

gl-inet / imagebuilder_archive

Historical Imagebuilder archive.
19 stars 7 forks source link

Dockerfile updates break the docker build #13

Open burnMyDread opened 5 years ago

burnMyDread commented 5 years ago

The new docker file is failing to compile. It is complaining about missing packages. When I installed these packages it started working. apt install gcc gawk unzip wget time
apt install g++ apt install libncurses5-dev

Johnex commented 5 years ago

Could you give me some more details? What system are you using to build? Could you post the command you used to build the image also? Which device is not compiling?

Using Docker on Ubuntu 18.04 LTS in both VM and WSL had no issues for me.

burnMyDread commented 5 years ago

I may be going crazy. I am running on Manjaro, I will check again when I get back in town.

burnMyDread commented 5 years ago

On manjaro I need to install wget in the container to get the ipk packages into the container.

burnMyDread commented 5 years ago

I also have to symlink /usr/bin/python2.7 to /usr/bin/python. I also had to install device-tree-compiler from the fix here: https://github.com/gl-inet/imagebuilder/issues/9 (These were all installed in the container.)

Johnex commented 5 years ago

Very strange. Seems like there is a difference between the Docker image Ubuntu downloads and the one Manjaro downloads. Isn't the whole point of Docker to have a consistent experience? >_>

Johnex commented 5 years ago

Could you give this one a try? I added the fixes you listed, but i don't have Manjaro to test on :(

https://github.com/Johnex/imagebuilder/blob/master/Dockerfile

Johnex commented 5 years ago

@burnMyDread Did you get a chance to test it out?

burnMyDread commented 5 years ago

That fixes the wget failures. I was seeing so other failures, are you guys using shellcheck.net and/or setting your bash scripts to fail on a non-zero return code? Here are some examples of what I am seeing: /src/imagebuilder/3.1/openwrt-imagebuilder-ar71xx-generic/build_dir/target-mips_24kc_musl/root-ar71xx/etc/init.d/gl_ssids: line 15: uci: command not found /src/imagebuilder/3.1/openwrt-imagebuilder-ar71xx-generic/build_dir/target-mips_24kc_musl/root-ar71xx/etc/init.d/glfw: line 3: /lib/functions.sh: No such file or directory line 9: /lib/functions/gl_util.sh: No such file or directory /src/imagebuilder/3.1/openwrt-imagebuilder-ar71xx-generic/build_dir/target-mips_24kc_musl/root-ar71xx/etc/init.d/vpn-service: line 13: get_model: command not found /src/imagebuilder/3.1/openwrt-imagebuilder-ar71xx-generic/build_dir/target-mips_24kc_musl/root-ar71xx/etc/init.d/vpn-service: line 14: check_guest_network_exist: command not found /src/imagebuilder/3.1/openwrt-imagebuilder-ar71xx-generic/build_dir/target-mips_24kc_musl/root-ar71xx/etc/init.d/startvpn: line 3: /lib/functions/gl_util.sh: No such file or directory

Johnex commented 5 years ago

@burnMyDread Those errors happen with the normal build as well, nothing to worry about 👍