search

gl-vis / regl-line2d

:part_alternation_mark: Draw 2d polyline with regl
https://gl-vis.github.io/regl-line2d
MIT License
59 stars 15 forks source link

Bump to-float32 package #50

Closed Seranicio closed 3 years ago

Seranicio commented 3 years ago

Upgrades to-float32 package and uses the new version to improve the performance when drawing.

You can see the to-float32 package changes here

Other packages PRs: here, here

@archmoj

cc: @alexcjohnson

Seranicio commented 3 years ago

Might be a good idea to upgrade the 'to-float32' on the other packages that plotly.js uses to draw. I hope you won't find it troubling doing that work for me :)

archmoj commented 3 years ago

Cool! I tested this with plotly.js here https://github.com/plotly/plotly.js/compare/regl-line2d-pull50 Would you be interested to submitted similar PRs to https://github.com/gl-vis/regl-scatter2d and https://github.com/gl-vis/regl-error2d? Thanks!!

Seranicio commented 3 years ago

I can only do the other PRs tomorrow if you are willing to wait

archmoj commented 3 years ago

I can only do the other PRs tomorrow if you are willing to wait

Anytime would be great. Thank you!

archmoj commented 3 years ago

:dancer: