search

gl186 / SprintFinish

Sprint 2 and final assessment project for Group 1 (Module 3 PGCert Clinical Bioniformatics Intro to Programming)
The Unlicense
0 stars 1 forks source link

Repo need to be in modular design before submission #21

Open ayurahman opened 8 months ago

ayurahman commented 8 months ago

Hi. I think our repo needs to be modularised at some point according to this structure namely app.py, endpoints and utils, as our final submission. Mentioned in the unit material. Snapshot attached. I think its similar to Variant Validator rest_api. rest_api modular design VV_rest_api_modular_design We can always ask Peter this afternoon to confirm.

ayurahman commented 8 months ago

On the other hand, attached is Peter's drawing peter drawing so which one should we follow...

tophie97 commented 8 months ago

I think both diagrams are pretty much saying the same thing but yes I agree modularizing is a good move. I actually did it on my local machine but the directory change seems to break apps. It would be nice to have it done in the main branch because our separate branches can be more freely manipulated.

ayurahman commented 8 months ago

Actually that is a good experiment/evidence Christoph. Its not like we dont want to modularised, its just when we did tried, that the app break....

ayurahman commented 8 months ago

so we can just stick to Peter's drawing then wink wink

gl186 commented 8 months ago

remember not to close issues even if completed so they can still be reviewed during assessment. on a previous issue I just left a comment saying it is completed but not closed for review purposes.

ayurahman commented 8 months ago

Sorry Georgia. My bad. I was tired confused and unconcious while doing that. And thank you for reopening them again.