Open tophie97 opened 8 months ago
we have blocked pushes onto main to protect the structure. how do you want to restructure it? from my side the structure looks correct in line with what Peter initially suggested
From what Peter recently suggested it seems that all of the module.py files need to be in the same path as Main.py rather than in separate folders. This would keep all modules in a centralized location and allow us to make a pythonproject.toml build file
ok I can unprotect the branch although it will leave it completely unprotected in a public repo. I will unprotect it then make the push but let me know as soon as done and I will re-protect is again?
That can work but perhaps we can double-check our ideas on the structure together first so that the main branch isn't altered too drastically.
it makes sense. like in sprint 1. we just have the modules set ups as they are now but instead of accessing their directory you open the modules directory and they are all listed. if we keep their naming consistent... module1, module2 etc it will be ok
Lisa just sent the link to the repo that we can base our format on in the slack channel. For ours to fall in line with that we still need to move the modules out of the folders like how I would have it in the push. Let me know what you think! I also created a build file which I am going to push into the team2 branch and it can be merged from there.
Thank you Georgia, along with Lisa I got the new format pushed and it now includes the Main.py containing a logger. I hope that the format change does not interfere with the other branch merges given those files exist in the previous file path setup.
Main repo modules need to be restructured but my push was rejected